Add basic AVRO files (translated copies of the parquet testing files to avro) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
approved these changes
Aug 29, 2021
alamb
reviewed
Aug 29, 2021
There was a problem hiding this comment.
@pitrou / @kiszk do you have any concerns or suggestions for adding several smaller AVRO files into the testing repository? They are used for apache/datafusion#910 and we may consider adding avro support to the main apache-rs repo as well.
|
This seems fine to me, but can you add a README explaining what these files are and how they were obtained? |
houqp
approved these changes
Aug 29, 2021
|
Looks good to me |
|
It would be possible to use arrow-python and fastavro to achieve the same, I just have a lot of Spark experience and I prefer typed so I went that way. |
|
Thanks @Igosuki ! I am sorry for the delayed response -- I am catching up from being on vacation and hope to help push your contributions over the line real soon now |
alamb
reviewed
Sep 9, 2021
|
All good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. : I used spark for the translation so there is some additional metadata in the files, but they can be removed.